Skip to content

chore: Fix useBaseComponent types #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

chore: Fix useBaseComponent types #3742

merged 2 commits into from
Aug 15, 2025

Conversation

just-boris
Copy link
Member

Description

Reduce number of type casting in our code

Related links, issue #, if available: n/a

How has this been tested?

Build passes

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.03%. Comparing base (fa5bdbd) to head (ecf1389).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
+ Coverage   97.02%   97.03%   +0.01%     
==========================================
  Files         835      835              
  Lines       24168    24158      -10     
  Branches     8492     8039     -453     
==========================================
- Hits        23449    23442       -7     
- Misses        670      710      +40     
+ Partials       49        6      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris marked this pull request as ready for review August 8, 2025 16:55
@just-boris just-boris requested a review from a team as a code owner August 8, 2025 16:55
@just-boris just-boris requested review from georgylobko, a team and taheramr and removed request for a team and georgylobko August 8, 2025 16:55
taheramr
taheramr previously approved these changes Aug 15, 2025
@just-boris just-boris added this pull request to the merge queue Aug 15, 2025
Merged via the queue into main with commit 8d844a1 Aug 15, 2025
38 checks passed
@just-boris just-boris deleted the fix-ref-types branch August 15, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants